Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/0.1.1 #36

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Rc/0.1.1 #36

merged 8 commits into from
Dec 11, 2024

Conversation

ml-ebs-ext
Copy link
Contributor

@ml-ebs-ext ml-ebs-ext commented Dec 10, 2024

Miguel: The changes contained in this PR don't impact the package documentation. We could talk mention the boxplot Y-axis log projection feature, but there are other undescribed features that require equal attention and, in the interest of time, I've decided not to go down that slippery slope.
This PR is best reviewed by looking at the individual commits, because they have been segmented so that each bite-sized change makes sense on its own.

Critical checks

  • Is the version number correct?

    • DESCRIPTION file

    • NEWS.md

  • Does the build pass?


Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots
  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...


QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

@ml-ebs-ext ml-ebs-ext requested a review from mattkorb December 10, 2024 14:52
@ml-ebs-ext ml-ebs-ext requested a review from a team as a code owner December 10, 2024 14:52
@ml-ebs-ext ml-ebs-ext merged commit 77140f0 into main Dec 11, 2024
12 checks passed
@ml-ebs-ext ml-ebs-ext deleted the rc/0.1.1 branch December 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants