CI: modernize #1946
CI: modernize #1946
Conversation
| target-version = "py311" | ||
|
|
||
| [tool.ruff.lint] | ||
| extend-select = ["I"] |
There was a problem hiding this comment.
We might add more rules later, I just did the minimum right now. It's open to PR :)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request focuses on modernizing the CI process by switching to 'ruff' for code formatting and linting, which is configured via 'pyproject.toml'. The changes are mostly automated code clean-up performed by 'ruff format'. The PR also addresses issues with duplicate entries in 'scripts/pt-langs.pt' and 'wikidict/lang/fr/ko_hangeul.py'.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Files deleted: Sourcery does not currently approve diffs with deleted files.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Ensure that the removal of mappings and changes in the code do not introduce any regressions or alter the intended behavior.
- Verify that the refactoring and code simplifications maintain the readability and maintainability of the codebase.
- Confirm that the changes made are consistent with the project's coding standards and practices.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| diacritiques = any( | ||
| char in texte for char in ["a", "i", "u", "â", "î", "û", "ã", "ĩ", "ũ", "°"] | ||
| ) | ||
| diacritiques = any(char in texte for char in ["a", "i", "u", "â", "î", "û", "ã", "ĩ", "ũ", "°"]) |
There was a problem hiding this comment.
suggestion (llm): Consider using a set for the diacritiques list since the 'in' operation is more efficient with sets than lists, especially if this operation is performed multiple times.
| and texte[curseur - 3 : curseur] | ||
| in (" el", " ^l", " bi", " fa", " ka", " la", " li", " wa") | ||
| and a_traiter != "'" # -- Pb de la hamza dans des mots comme bi'r, ne pas traiter comme un préfixe | ||
| and texte[curseur - 3 : curseur] in (" el", " ^l", " bi", " fa", " ka", " la", " li", " wa") |
There was a problem hiding this comment.
suggestion (llm): The tuple of strings used for checking the substring in 'texte' is repeated multiple times. Consider storing it in a variable to avoid repetition and improve maintainability.
| and texte[curseur - 2 : curseur] != "ât" | ||
| and texte[curseur + 1] != "é" | ||
| ): | ||
| if texte[curseur - 1] != "@" and texte[curseur - 2 : curseur] != "ât" and texte[curseur + 1] != "é": |
There was a problem hiding this comment.
suggestion (llm): This conditional check is complex and repeated in the code. Consider refactoring it into a separate function for clarity and reuse.
| @@ -182,7 +182,6 @@ | |||
| "ㅈㄴ": "ㄴㄴ", | |||
| "ㅊㄴ": "ㄴㄴ", | |||
| "ㅌㄴ": "ㄴㄴ", | |||
| "ㅎㄴ": "ㄴㄴ", | |||
There was a problem hiding this comment.
question (llm): Ensure that the removal of the 'ㅎㄴ': 'ㄴㄴ' mapping is intentional and does not affect the correctness of the Hangul processing.
| lua_code = re.sub( | ||
| r"aliases\s*=\s*{([^}]*)}", "", lua_code, 0, re.MULTILINE | re.DOTALL | ||
| ) | ||
| lua_code = re.sub(r"aliases\s*=\s*{([^}]*)}", "", lua_code, 0, re.MULTILINE | re.DOTALL) |
There was a problem hiding this comment.
question (llm): The simplification of the regex substitution is good, but ensure that it correctly handles all cases, especially when dealing with nested or complex Lua table structures.
| phrase = ("D" if data["m"] else "d") + ( | ||
| "érivée" if data["f"] in ("1", "oui", "o", "i") else "érivé" | ||
| ) | ||
| phrase = ("D" if data["m"] else "d") + ("érivée" if data["f"] in ("1", "oui", "o", "i") else "érivé") |
There was a problem hiding this comment.
praise (llm): The refactoring of the conditional phrase construction improves readability by removing unnecessary parentheses.
Use
ruff+pyproject.tomlfor configurations../checks.shis blazing fast now (it was always slow when dealing with the bigsvg_cache.pyfile).Most of the changes are done by
ruff format, it's a one-time clean-up.Relevant issues found, and fixed, are:
scripts/pt-langs.pywas not handling duplicate entries;wikidict/lang/fr/ko_hangeul.pyhad a duplicate entry.