[CA] Fix support for "etim-s" template #1945
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces an enhancement to the 'etim-s' template handling in the Catalan Wiktionary parsing logic. It modifies the template processing to accommodate cases where the template contains more than two parameters, ensuring that the correct information is extracted and displayed.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the assumption that the last part is the desired output when there are more than 3 parts is valid across all use cases.
- Consider adding a comment in the code explaining the logic behind choosing the last part as the output for cases with more than 3 parts, to clarify the intent for future maintainers.
- Review the possibility of edge cases where the 'parts' list might be empty and ensure that the code handles such scenarios gracefully.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -104,7 +104,8 @@ | |||
| # {{romanes|XIX}} | |||
| "romanes": "small_caps(parts[-1].lower())", | |||
| # {{etim-s|ca|XIV}} | |||
| "etim-s": "'segle ' + parts[2]", | |||
| # {{etim-s|ca|XVII|1617}} | |||
| "etim-s": "('segle ' + parts[2]) if len(parts) == 3 else parts[-1]", | |||
There was a problem hiding this comment.
question (llm): The updated logic for 'etim-s' now handles an additional case where there might be more than 3 parts. However, it assumes that the last part is the desired output when there are more than 3 parts. It would be beneficial to confirm that this assumption is always valid for the input data.
|
Wow, I didn't see the new Sourcery 😮 |
Fixes #1944