Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RO] Many words are missing their inflection #2085

Open
dragostis opened this issue Jul 23, 2024 · 5 comments
Open

[RO] Many words are missing their inflection #2085

dragostis opened this issue Jul 23, 2024 · 5 comments

Comments

@dragostis
Copy link

dragostis commented Jul 23, 2024

It doesn't seem to be caused by a missing template, but many words seem to be missing their inflection on Kobo. For example, looking up "pietre" does not find the correct root "piatră".

I haven't debugged this yet, but it definitely seems like some words are not missing their inflection, but most of them do.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@BoboTiG
Copy link
Owner

BoboTiG commented Jul 23, 2024

I did not translate the page, but https://ro.wiktionary.org/wiki/pietre just does not exist. So, it is expected to not be found on the Kobo.

@BoboTiG
Copy link
Owner

BoboTiG commented Jul 23, 2024

The current process to add variants would be to create the https://ro.wiktionary.org/wiki/pietre page, and use a specific template to tell this is the inflexion of "piatră".

FTR we currently look at those variants:

# Variantes
variant_titles = tuple(section for section in sections if section not in etyl_section)
variant_templates = (
"{{adj form of",
"{{forma de",
)
# All forms of a words (for variants)
forma_de = (
"forma de acuzativ feminin la plural pentru",
"forma de articulat singular pentru",
"forma de dativ feminin la plural pentru",
"forma de dativ feminin la singular pentru",
"forma de dativ-genitiv și de vocativ plural articulat pentru",
"forma de enitiv-dativ singular articulat pentru",
"forma de feminin neutru și plural pentru",
"forma de feminin pentru",
"forma de feminin plural pentru",
"forma de feminin singular articulat pentru",
"forma de feminin singular nehotărât pentru",
"forma de feminin singular pentru",
"forma de feminin și neutru plural pentru",
"forma de genitiv dativ singular pentru",
"forma de genitiv-dativ plural articulat pentru",
"forma de genitiv-dativ singular articulat pentru",
"forma de genitiv-dativ și vocativ plural articulat pentru",
"forma de gerunziu pentru",
"forma de maculin plural pentr",
"forma de maculin plural pentru",
"forma de mascuklin plural pentru",
"forma de masculin feminin singular pentru",
"forma de masculin plural pentru",
"forma de masculin plural singular pentru",
"forma de masculin pluralpentru",
"forma de masculin plurl pentru",
"forma de masculin și feminin plural genitiv-dativ pentru",
"forma de masculin, neutru și feminin plural pentru",
"forma de neutru plural pentru",
"forma de nominativ-acuzativ plural pentru",
"forma de participiu pentru",
"forma de participiu trecut pentru",
"forma de persoana a I-a plural la conjunctiv prezent pentru",
"forma de persoana a I-a plural la imperfect pentru",
"forma de persoana a I-a plural la mai mult ca perfect pentru",
"forma de persoana a I-a plural la perfect simplu pentru",
"forma de persoana a I-a plural la prezent pentru",
"forma de persoana a I-a singular la conjunctiv prezent pentru",
"forma de persoana a I-a singular la imperfect pentru",
"forma de persoana a I-a singular la mai mult ca perfect pentru",
"forma de persoana a I-a singular la perfect simplu pentru",
"forma de persoana a I-a singular la prezent pentru",
"forma de persoana a II-a plural la conjunctiv prezent pentru",
"forma de persoana a II-a plural la imperativ entru",
"forma de persoana a II-a plural la imperativ pentru",
"forma de persoana a II-a plural la imperfect pentru",
"forma de persoana a II-a plural la mai mult ca perfect pentru",
"forma de persoana a II-a plural la perfect simplu pentru",
"forma de persoana a II-a plural la prezent pentru",
"forma de persoana a II-a singular la conjunctiv prezent pentru",
"forma de persoana a II-a singular la imperativ pentru",
"forma de persoana a II-a singular la imperfect pentru",
"forma de persoana a II-a singular la indicativ prezent pentru",
"forma de persoana a II-a singular la mai mult ca perfect pentru",
"forma de persoana a II-a singular la perfect simplu pentru",
"forma de persoana a II-a singular la prezent indicativ pentru",
"forma de persoana a II-a singular la prezent pentru",
"forma de persoana a II-a singular la subjonctiv prezent pentru",
"forma de persoana a III-a plural la conjunctiv prezent pentru",
"forma de persoana a III-a plural la imperfect pentru",
"forma de persoana a III-a plural la mai mult ca perfect pentru",
"forma de persoana a III-a plural la perfect simplu pentru",
"forma de persoana a III-a plural la prezent indicativ pentru",
"forma de persoana a III-a plural la prezent pentru",
"forma de persoana a III-a plural la timpul condițional-optativ pentru",
"forma de persoana a III-a singular la conjunctiv prezent pentru",
"forma de persoana a III-a singular la imperfect indicativ pentru",
"forma de persoana a III-a singular la imperfect pentru",
"forma de persoana a III-a singular la mai mult ca perfect pentru",
"forma de persoana a III-a singular la perfect simplu pentru",
"forma de persoana a III-a singular la perfect simplu pentru",
"forma de persoana a III-a singular la prezent indicativ pentru",
"forma de persoana a III-a singular la prezent pentru",
"forma de persoana a III-a singular la timpul condițional-optativ pentru",
"forma de plural articulat pentru",
"forma de plural la feminin și neutru pentru",
"forma de plural masculin pentru",
"forma de plural nearticulat pentru",
"forma de plural neatriculat pentru",
"forma de plural pentru",
"forma de singulaar articulat pentru",
"forma de singular articulat",
"forma de singular articulat pentru",
"forma de singular articulată pentru",
"forma de singular nearticulat pentru",
"forma de singular vocativ pentru",
"forma de singular și plural genitiv nearticulat pentru",
"forma de singulat articulat pentru",
"forma de vocativ plural articulat pentru",
"forma de vocativ plural pentru",
"forma de vocativ singular articulat pentru",
"forma de vocativ singular pentru",
)

@dragostis
Copy link
Author

Thanks for the reply!

I wonder if an alternative would be to use the declination tables (e.g. on the word's root page) just to generate cross-linking.

@BoboTiG
Copy link
Owner

BoboTiG commented Jul 23, 2024

I wonder if an alternative would be to use the declination tables (e.g. on the word's root page) just to generate cross-linking.

Actually that is a great idea! And going further, it is something doable for all locales.

That will require quite some work, at first sight. But I'm not against the idea, and might try something later on.
If someone wants to give a try, I will love to review some code too!

@dragostis
Copy link
Author

dragostis commented Jul 23, 2024

In the case of Romanian specifically, it seems like only en.wiktionary.org has complete inflection tables compared to the ro.wiktionary.org source that has partial ones.

Since I'm not familiar with the code, would you be willing to please leave some high-level approach to add this? I might take a stab at it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants