Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: revoke token approval after swaps #49

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions tests/test_avnu_swap.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -1269,3 +1269,62 @@ fn test_fibrous_swap_should_fail_for_token_not_supported() {
);
}

#[test]
#[fork(url: "https://starknet-mainnet.public.blastapi.io/rpc/v0_7", block_number: 996491)]
#[should_panic(expected: 'Insufficient Allowance')]
fn test_swap_should_fail_after_token_approval_is_revoked_avnu() {
let autoSwappr_dispatcher = __setup__();
let previous_amounts = get_wallet_amounts(ADDRESS_WITH_FUNDS());

approve_amount(
STRK_TOKEN().contract_address,
ADDRESS_WITH_FUNDS(),
autoSwappr_dispatcher.contract_address,
AMOUNT_TO_SWAP_STRK
);

let params1 = get_swap_parameters(SwapType::strk_usdt);

call_avnu_swap(
autoSwappr_dispatcher,
params1.token_from_address,
params1.token_from_amount,
params1.token_to_address,
params1.token_to_amount,
params1.token_to_min_amount,
params1.beneficiary,
params1.integrator_fee_amount_bps,
params1.integrator_fee_recipient,
params1.routes
);

let post_swap_amounts = get_wallet_amounts(ADDRESS_WITH_FUNDS());
assert_eq!(
post_swap_amounts.strk,
previous_amounts.strk - AMOUNT_TO_SWAP_STRK,
"First swap should decrease STRK balance"
);

approve_amount(
STRK_TOKEN().contract_address,
ADDRESS_WITH_FUNDS(),
autoSwappr_dispatcher.contract_address,
0
);

let params2 = get_swap_parameters(SwapType::strk_usdt);

call_avnu_swap(
autoSwappr_dispatcher,
params2.token_from_address,
params2.token_from_amount,
params2.token_to_address,
params2.token_to_amount,
params2.token_to_min_amount,
params2.beneficiary,
params2.integrator_fee_amount_bps,
params2.integrator_fee_recipient,
params2.routes
);
}

37 changes: 37 additions & 0 deletions tests/test_fibrous_swap.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -499,3 +499,40 @@ fn test_fibrous_swap_should_fail_for_token_not_supported() {
call_fibrous_swap(autoSwappr_dispatcher, routeParams, swapParams);
}

#[test]
#[fork(url: "https://starknet-mainnet.public.blastapi.io/rpc/v0_7", block_number: 993231)]
#[should_panic(expected: 'Insufficient Allowance')]
fn test_swap_should_fail_after_token_approval_is_revoked_fibrous() {
let autoSwappr_dispatcher = __setup__();
let previous_amounts = get_wallet_amounts(ADDRESS_WITH_FUNDS());

approve_amount(
STRK_TOKEN().contract_address,
ADDRESS_WITH_FUNDS(),
autoSwappr_dispatcher.contract_address,
AMOUNT_TO_SWAP_STRK
);

let (routeParams1, swapParams1) = get_swap_parameters(SwapType::strk_usdt);

call_fibrous_swap(autoSwappr_dispatcher, routeParams1, swapParams1);

let post_swap_amounts = get_wallet_amounts(ADDRESS_WITH_FUNDS());
assert_eq!(
post_swap_amounts.strk,
previous_amounts.strk - AMOUNT_TO_SWAP_STRK,
"First swap should decrease STRK balance"
);

approve_amount(
STRK_TOKEN().contract_address,
ADDRESS_WITH_FUNDS(),
autoSwappr_dispatcher.contract_address,
0
);

let (routeParams2, swapParams2) = get_swap_parameters(SwapType::strk_usdt);

call_fibrous_swap(autoSwappr_dispatcher, routeParams2, swapParams2);
}