Efficient pool info parsing #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkarakostas
force-pushed
the
efficient_pool_info_parsing
branch
from
dd22c85 to
d2a5a52
Compare
dimkarakostas
changed the title
dimkarakostas
force-pushed
the
efficient_pool_info_parsing
branch
from
9a95c9e to
6255b8c
Compare
dimkarakostas
changed the title
dimkarakostas
force-pushed
the
efficient_pool_info_parsing
branch
from
6255b8c to
90ba9f5
Compare
LadyChristina
requested changes
Jul 19, 2023
src/helpers/helper.py
Outdated
| for info in coinbase_tags.values(): | ||
| known_entities.add(info['name']) | ||
| except FileNotFoundError: | ||
| coinbase_tags = {} |
There was a problem hiding this comment.
Is this needed? We could just use pass if we don't want anything to happen in case of an exception
src/helpers/helper.py
Outdated
| for cluster in clusters.keys(): | ||
| known_entities.add(cluster) | ||
| except FileNotFoundError: | ||
| clusters = {} |
src/helpers/helper.py
Outdated
| for address_info in pool_addresses.values(): | ||
| known_entities.add(address_info['name']) | ||
| except FileNotFoundError: | ||
| pool_addresses = {} |
src/helpers/helper.py
Outdated
| """ | ||
| try: | ||
| with open(HELPERS_DIR / f'pool_information/coinbase_tags/{project_name}.json') as f: | ||
| pool_data = json.load(f) |
There was a problem hiding this comment.
not important but pool_tags would be a more suitable name for this variable
| @@ -44,8 +44,23 @@ def test_map(setup_and_cleanup): | |||
| pool_info_dir, test_input_dir, test_output_dir = setup_and_cleanup | |||
| project = 'sample_bitcoin' | |||
|
|
|||
| shutil.copy2(str(pool_info_dir / 'bitcoin.json'), | |||
| str(pool_info_dir / f'{project}.json')) # Create a temp pool info file for sample | |||
| try: | |||
There was a problem hiding this comment.
I don't think it's good practice to use try-except blocks in tests, but I also don't mind leaving these for now as long as we update them when we refactor tests more broadly, e.g. for #53
| @@ -17,45 +17,57 @@ coinbase addresses, so it doesn't perform any extra processing on the raw data. | |||
|
|
|||
| ## Pool Information | |||
|
|
|||
| To assist the mapping process, the directory `helpers/pool_information/` contains files named `<project_name>.json`, with | |||
| relevant pool information, structured as follows: | |||
| To assist the mapping process, the directory `helpers/pool_information/` contains | |||
docs/mappings.md
Outdated
| There exist three subdirectories. In each subdirectory there exists a file for | ||
| the corresponding ledger data, if such data exists. | ||
|
|
||
| `coinbase_tags` defines information about pools and miners. Each key |
There was a problem hiding this comment.
I would say information about "block creators" as it is captures more systems. We can keep pools and miners as examples in brackets.
dimkarakostas
force-pushed
the
efficient_pool_info_parsing
branch
from
1e1c6fe to
23813c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #79