Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic send flow #152

Open
wants to merge 12 commits into
base: gh-pages
Choose a base branch
from
Binary file added assets/images/send/layout-blocks-address-big.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-address.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-address@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make a couple of tweaks:

  • Little bit of padding for "Send all"
  • Make the input field fill the available space so it can be easily tapped to focus.

Would also be nice to be able to tap the available balance in the error message, to "Send all". That might be what the user wants to do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the label field is a fixed width, we may need to define that as well. That could get a little tricky across input fields, we the text size is dynamic and user-adjustable.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-amount.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-amount@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-fees-big.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-fees.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-fees@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-note-big.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-note.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/send/layout-blocks-note@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 38 additions & 0 deletions pages/send/send-form-inputs.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ Inline validation checks include:
- Wrong Format: Error – This is not a valid Bitcoin address.
- Potentially more

{% include picture.html
image = "/assets/images/send/layout-blocks-address.png"
retina = "/assets/images/send/layout-blocks-address@2x.png"
big = "/assets/images/send/layout-blocks-address-big.png"
alt-text = "Layout blocks of the address input component."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just throw the image into AI and have it create alt text?

width = 800
height = 703
%}

## Amount

The transaction amount can be entered in two denominations: bitcoins or Satoshis. Users also have the option to send the full wallet balance.
Expand All @@ -57,6 +66,16 @@ Inline validation checks include:
- Full Send: Warning – You are sending your entire balance.
- Potentially more

{% include picture.html
image = "/assets/images/send/layout-blocks-amount.png"
retina = "/assets/images/send/layout-blocks-amount@2x.png"
big = "/assets/images/send/layout-blocks-amount-big.png"
alt-text = "Layout blocks of the amount input component."
width = 800
height = 1034
%}


## Note to self

The note to self is recommended for each transaction. It can have up to 255 characters, as recommended in [BIP-329](https://github.com/bitcoin/bips/blob/master/bip-0329.mediawiki).
Expand All @@ -70,6 +89,16 @@ The note to self is recommended for each transaction. It can have up to 255 char
height = 418
%}

{% include picture.html
image = "/assets/images/send/layout-blocks-note.png"
retina = "/assets/images/send/layout-blocks-note@2x.png"
big = "/assets/images/send/layout-blocks-note-big.png"
alt-text = "Layout blocks of the note to self input component."
width = 800
height = 808
%}


## Fee selection

The application offers three standard fee options, each corresponding to a different confirmation speed. In rare cases where all three options have the same fee, the fastest option is selected by default.
Expand All @@ -84,6 +113,15 @@ The application offers three standard fee options, each corresponding to a diffe
height = 507
%}

{% include picture.html
image = "/assets/images/send/layout-blocks-fees.png"
retina = "/assets/images/send/layout-blocks-fees@2x.png"
big = "/assets/images/send/layout-blocks-fees-big.png"
alt-text = "Layout blocks of the fee selection component."
width = 800
height = 561
%}

### Custom fees

Users can enable the custom fee option from the send options dropdown. By default, the custom fee field is pre-filled with the value of the default option in the standard fee selection.
Expand Down