Update silent payments page #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created sub-folders to group related pages (e.g. design system). - moved contacts and silent payment pages to milestone 1.8 -
- Text tweaks - Added payment request mockups - Added mockup of the review screen with a tooltip
GBKS
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
ACK. Good to merge.
A few follow-up things:
- For clearing a payment request, these designs use "Create new", the web prototype uses "Clear", and the receive screen is missing the functionality. Let's standardize.
- The tabs use the term "invoice", which is not used anywhere else. Let's get rid of it.
- The QR code has a background color and padding, which the receive screen does not. Let's remove it.
- The primary button is labelled "Share request". We just use "Share" elsewhere, let's go with the simpler option.
- I like how the derived address is accessible in the review screen. I wonder if that can be more explicit somehow. The little arrow is clean, but does not explain things very well. Maybe the derived address has its own label or so? Not sure.
- Another approach is that we show an intro page to silent payment addresses the first time the user encounters them.
- The term "sub-address" does not seem quite right. I was looking at the silent payments page for guidance, but could also not find anything there. Something to look into.
I'll add those to #143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the silent payments page with inital content and early stage concepts for receiving and sending to silent payment addresses.