Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): increased custom slippage range to 0 to 1000 #4172

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

fullstackninja864
Copy link
Contributor

@fullstackninja864 fullstackninja864 commented Feb 27, 2024

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #4170

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

Build preview for DeFiChain Wallet is ready!

Built with commit 01bcc58

https://expo.io/@defichain/wallet?release-channel=pr-preview-4172

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.32%. Comparing base (c9e7f5d) to head (9b18600).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4172       +/-   ##
===========================================
- Coverage   55.94%   41.32%   -14.63%     
===========================================
  Files         438      438               
  Lines       12501    12502        +1     
  Branches     4141     4142        +1     
===========================================
- Hits         6994     5166     -1828     
- Misses       5422     7281     +1859     
+ Partials       85       55       -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee merged commit e4de099 into main Feb 27, 2024
12 of 17 checks passed
@pierregee pierregee deleted the harsh/update-slippage-range branch February 27, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not set slipage above 100%
3 participants