Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): cfp valid address warning #4150

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

pierregee
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 54ae04c

https://expo.io/@defichain/wallet?release-channel=pr-preview-4150

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7dd1836) 61.48% compared to head (dfdf0c3) 61.44%.

Files Patch % Lines
...igator/screens/Portfolio/components/AddressRow.tsx 33.33% 2 Missing ⚠️
.../screens/Portfolio/screens/OCG/CFPDetailScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4150      +/-   ##
==========================================
- Coverage   61.48%   61.44%   -0.05%     
==========================================
  Files         438      438              
  Lines       12469    12473       +4     
  Branches     4127     4128       +1     
==========================================
- Hits         7667     7664       -3     
- Misses       4711     4718       +7     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee merged commit 3fbff35 into main Dec 1, 2023
14 of 15 checks passed
@pierregee pierregee deleted the pierregee/fix-address-warning-on-cfp-creation branch December 1, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants