Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): fully disable send to evm #4138

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

pierregee
Copy link
Contributor

What this PR does / why we need it:

  • Bug: Users are able to send to evm address even if evm + transferDomain feature is disabled via the flag

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

lykalabrada
lykalabrada previously approved these changes Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit f0ba434

https://expo.io/@defichain/wallet?release-channel=pr-preview-4138

@pierregee pierregee merged commit e0d2511 into main Nov 21, 2023
@pierregee pierregee deleted the pierregee/fully-disable-send-to-evm-address branch November 21, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants