Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-ux): display error announcement when evm and eth urls are incorrect #4136

Closed
wants to merge 3 commits into from

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

Also show error announcement when custom evm urls are incorrect
image

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@lykalabrada lykalabrada self-assigned this Nov 17, 2023
@lykalabrada lykalabrada changed the title chore(ui-ux): display error banner when evm and eth urls are incorrect chore(ui-ux): display error announcement when evm and eth urls are incorrect Nov 17, 2023
Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 71c2e9c

https://expo.io/@defichain/wallet?release-channel=pr-preview-4136

@pierregee pierregee closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants