Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): convert transfer domain #4062

Closed
wants to merge 8 commits into from

Conversation

Ramyasivan
Copy link

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@pierregee pierregee changed the title Ramya/e2e convert transfer domain chore(e2e): convert transfer domain Oct 16, 2023
@github-actions github-actions bot added the kind/chore Non feature change label Oct 16, 2023
@pierregee pierregee force-pushed the ramya/e2e-convert-transferDomain branch from 38578cb to 71fe7f9 Compare October 17, 2023 02:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 7344a3f

https://expo.io/@defichain/wallet?release-channel=pr-preview-4062

@Ramyasivan Ramyasivan force-pushed the ramya/e2e-convert-transferDomain branch from e464ee9 to fe6dab7 Compare October 18, 2023 07:44
@Ramyasivan Ramyasivan force-pushed the ramya/e2e-convert-transferDomain branch from 1ea0c5b to 9e6cc19 Compare October 27, 2023 03:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #4062 (acb5a62) into main (d61a44b) will decrease coverage by 16.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #4062       +/-   ##
===========================================
- Coverage   56.06%   40.06%   -16.01%     
===========================================
  Files         438      438               
  Lines       12353    12353               
  Branches     4090     4090               
===========================================
- Hits         6926     4949     -1977     
- Misses       5343     7354     +2011     
+ Partials       84       50       -34     
Files Coverage Δ
...igator/screens/Portfolio/components/AddressRow.tsx 73.26% <ø> (ø)

... and 106 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@thedoublejay
Copy link
Contributor

woowww good job @Ramyasivan

cy.getByTestID("dfi_token_amount").contains("5.0000");
cy.go("back");
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
});
});

@pierregee pierregee closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants