Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container submodule #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix container submodule #118

wants to merge 2 commits into from

Conversation

bbartley
Copy link
Collaborator

@bbartley bbartley commented Mar 2, 2022

The container-ontology submodule was previously taken from @rpgoldman 's private repo. This PR replaces the submodule with the public fork of the container-ontology.

@bbartley bbartley requested a review from rpgoldman March 2, 2022 16:25
@bbartley
Copy link
Collaborator Author

bbartley commented Mar 2, 2022

@rpgoldman this PR is a minor change to the project organization that doesn't affect any of the code; I added you as reviewer just in case you have other plans for how the PAML repo should be organized--I know you have actively been developing the container-api in the last few days

@rpgoldman
Copy link
Collaborator

How about I add a paml branch to the repo, and then you can track that branch in the submodule?

@bbartley
Copy link
Collaborator Author

Hi @rpgoldman ... that should be fine as long as I have write access to that branch. I want to be able to edit the container turtle files and submit PRs to the container ontology, even while working in the context of the large PAML project space.

@rpgoldman
Copy link
Collaborator

Hi @rpgoldman ... that should be fine as long as I have write access to that branch. I want to be able to edit the container turtle files and submit PRs to the container ontology, even while working in the context of the large PAML project space.

What I was trying to suggest was to give PAML users a relatively stable branch to deal with, for people who are not editing the container ontology.

I believe that’s compatible with what you want, but you should check out the sub module, cd to the directory, check out main , make your own topic branch, and work from there.

Then, when we have something we are happy with, we can update the paml branch to point to that, and Dan, Jake, etc. would all get that.

@rpgoldman
Copy link
Collaborator

@bbartley ping?

@danbryce
Copy link
Collaborator

@bbartley This is pretty old. Rebase or delete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants