Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Rendering Profile #806

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Auto-Rendering Profile #806

merged 7 commits into from
Jan 19, 2024

Conversation

sahar-frikha
Copy link
Member

This pull request has been created by a guithub action, after adding/updating a profile in the specifications repo.

@gtsueng gtsueng requested review from nsjuty and ljgarcia December 21, 2023 18:59
Copy link
Collaborator

@ljgarcia ljgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile created from GitHub actions looks fine (after updating hierarchy and redirections which do not work well in GitHub actions). However, some information is missing and should be added to this PR.
@sneumann @gtsueng @ivanmicetic could you please add the use cases? They should go to /useCases/DefinedTerm and also the group this profile should go to? I would suggest Dataset.
There are no embedded examples in the page, cannot those be created with DDE as well? If not, see if you can add a couple by hand. Not mandatory/blocking but nice to have.
image

Thanks.

@ljgarcia
Copy link
Collaborator

@sneumann @gtsueng @ivanmicetic any updates? Thanks

@sneumann
Copy link
Contributor

As I can't edit this PR, I have created #808 to replace this one.
I hope to have adressed the requested changes.
Yours, Steffen

@ljgarcia
Copy link
Collaborator

ljgarcia commented Jan 19, 2024

As I can't edit this PR, I have created #808 to replace this one. I hope to have adressed the requested changes. Yours, Steffen

When trying your repo, I get an error for the DefineTerm.html "mapping values are not allowed in this context at line 56 column 12". I will implement your changes here.

Copy link
Collaborator

@ljgarcia ljgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can go now

@ljgarcia ljgarcia merged commit 9d42c03 into master Jan 19, 2024
1 check passed
@ljgarcia ljgarcia deleted the 2023_12_21-18_29 branch January 19, 2024 15:39
@sneumann
Copy link
Contributor

Hi, I am still unable to test my changes locally, so thanks for catching mapping values are not allowed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants