Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proposal procedures to tx builder #88

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

AngelCastilloB
Copy link
Member

@AngelCastilloB AngelCastilloB commented Nov 29, 2024

Description

Add proposal procedures to TX builder, and add governance related examples.

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

Copy link

github-actions bot commented Nov 29, 2024

MISRA C Logo

MISRA Guideline Compliance Summary

Commit: ea2a972a704d048b683fd892ef60073552e08466
Date: 2024-12-02
Guidelines: MISRA C 2012
Checking Tool: Cppcheck
Result: Compliant ✅

🎉 No MISRA C 2012 Violations Found!

You can download the complete report from: MISRA C Report

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 95.72519% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/src/transaction_builder/transaction_builder.c 97.23% 16 Missing ⚠️
lib/src/transaction_body/transaction_output.c 76.92% 9 Missing ⚠️
lib/src/transaction_body/transaction_body.c 60.00% 2 Missing ⚠️
lib/src/address/internals/reward_addr_pack.c 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AngelCastilloB AngelCastilloB force-pushed the fix/fix-fuzz-findings branch 3 times, most recently from a5b9b1e to cf58969 Compare November 29, 2024 20:02
@AngelCastilloB AngelCastilloB changed the title fix: fix fuzz findings feat: add proposal procedures to tx builder Dec 1, 2024
@AngelCastilloB AngelCastilloB force-pushed the fix/fix-fuzz-findings branch 3 times, most recently from 27d44ec to e8209ed Compare December 2, 2024 13:23
@AngelCastilloB AngelCastilloB merged commit bd01a96 into main Dec 2, 2024
7 checks passed
@AngelCastilloB AngelCastilloB deleted the fix/fix-fuzz-findings branch December 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant