Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added base object type #11

Closed
wants to merge 2 commits into from
Closed

Conversation

luisdbianchi
Copy link
Member

Description

We need to add a base object type to avoid code duplication in the ref counting mechanism of all objects

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@luisdbianchi luisdbianchi force-pushed the feat/add-base-object-type branch from d24eccd to 6a50095 Compare March 1, 2024 03:46
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 97.93814% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.32%. Comparing base (d57b3ab) to head (fd72398).
Report is 21 commits behind head on main.

Files Patch % Lines
lib/src/buffer/buffer.c 97.87% 1 Missing ⚠️
lib/src/cbor/cbor_writer.c 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   89.00%   89.32%   +0.32%     
==========================================
  Files           7        9       +2     
  Lines         864      890      +26     
==========================================
+ Hits          769      795      +26     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luisdbianchi luisdbianchi force-pushed the feat/add-base-object-type branch from 6a50095 to 31622f1 Compare March 1, 2024 06:31
@luisdbianchi luisdbianchi force-pushed the feat/add-base-object-type branch from b5703b3 to fd72398 Compare March 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants