Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate redundancy surrounding rec_with_table #28

Open
reikookamoto opened this issue Oct 13, 2023 · 0 comments
Open

Eliminate redundancy surrounding rec_with_table #28

reikookamoto opened this issue Oct 13, 2023 · 0 comments
Assignees

Comments

@reikookamoto
Copy link
Collaborator

I have been browsing through the source code of flow packages and noticed that the rec_with_table function is defined in multiple places:

After chatting with @DougManuel and @yulric, it appears that this duplication is due to the order in which the different flow packages were developed (i.e., cchsflow, elderflow, followed by recodeflow). Ideally, some refactoring needs to be done such that database-specific flow packages are mainly concerned with the variable sheet, details sheet, and derived variable functions, and recodeflow is taken as a dependency such that recodeflow::rec_with_table can be used with consistency.

@reikookamoto reikookamoto self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant