Disable the use of the nullable type expression for sorting #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/Inforitnl/Sieve into feature/disableSortNullableTypeExpression
|
I think this is also an option for #110 |
HBTeun
changed the title
Mastermindzh
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Looks good. All the comments from our internal review have been resolved.
|
Any window for release? |
|
If no feedback is provided I'll merge the PR on next Monday, March 28th, 2022 |
|
@hasanmanzak, if you could, please 😄. Will there also be a new version published to nuget right away? |
Yes. It's already been published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB has issues with the expression created when sorting on nullable types.
So I created an option to disable it.
If there is anything I need to do to improve it please let us know