Fix CLI::UI compatibility #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzane
force-pushed
the
rzane/fix-cli-ui
branch
from
d64abf4 to
47d883c
Compare
smudge
approved these changes
Feb 10, 2025
rzane
force-pushed
the
rzane/fix-cli-ui
branch
from
47d883c to
3c7a303
Compare
rzane
force-pushed
the
rzane/fix-cli-ui
branch
from
62e171c to
140b413
Compare
rzane
commented
Feb 11, 2025
Comment on lines
3
to
5
| require 'spec_helper' | ||
| require 'sorbet-runtime' | ||
| require 'demo_mode/cli' |
There was a problem hiding this comment.
This change reproduces the issue. See https://github.com/Shopify/cli-ui/blob/v2.3.0/lib/cli/ui.rb#L4-L6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
persona:createtask is failing on newer versions ofCLI::UI. It seems like we're using prompts in a way thatCLI::UIwasn't designed to be used.CLI::UI expects: