fix get_utc_datetime semantics #10507
Open
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, python 3.11-, the returned datetime had no timezone python 3.11+, the returned datetime has a timezone now, the returned datetime has a timezone this is important because some common functions error when operating on datetimes without a timezone. for instance, comparison fails: can't compare offset-naive and offset-aware datetimes. these functions will fail on py3.11- and succeed on py3.11+.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
🐛 Bug Fix
Changes
previously: python 3.11-, the returned datetime had no timezone; python 3.11+, the returned datetime has a timezone
now: the returned datetime has a timezone
this is important because some common functions error when operating on datetimes without a timezone.
for instance, comparison fails: can't compare offset-naive and offset-aware datetimes.
these functions will fail on py3.11- and succeed on py3.11+.