Expanded the _validate_anthropic_response function to include comprehensive checks #10505
+371
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehensive checks for response structure, ensuring all required fields are validated. - Updated unit tests to utilize the new validation function for verifying response integrity in both non-streaming and streaming scenarios.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
May 2, 2025
| if isinstance(response, AsyncIterator): | ||
| async for chunk in response: | ||
| print("chunk=", chunk) | ||
| collected_chunks.append(chunk) | ||
| if "content" in chunk and len(chunk["content"]) > 0: | ||
| for content_block in chunk["content"]: |
There was a problem hiding this comment.
please can you validate the streaming chunks received
There was a problem hiding this comment.
Done, also using Anthropic SDK for non-streaming validation.
|
One approach - use anthropic sdk's pydantic object and use For streaming, try to validate each chunk |
- Upgraded Poetry version in poetry.lock to 2.0.1. - Added the Anthropic library (version 0.50.0) to pyproject.toml. - Enhanced unit tests for Anthropic messages to utilize the new validation method and updated model references for consistency. - Improved response validation in tests to ensure compliance with the Anthropic Messages API structure.
|
Testcase: |
…m_messages_support_update_tc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Test
Changes