Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add blueprint for test_brake for CARLA simulator tests #292

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented Jul 16, 2024

Description

Threshold to check if car has properly brake is flaky. Fixing a blueprint to get more consistency between runs! Also, slightly increasing steps needed to perform braking behavior to ensure the threshold is satisfied!

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo changed the title fix: increase test_brake steps for CARLA simulation tests fix: fix blueprint for test_brake steps for CARLA simulator tests Jul 16, 2024
@abanuelo abanuelo requested review from Eric-Vin and dfremont July 16, 2024 19:05
@abanuelo abanuelo changed the title fix: fix blueprint for test_brake steps for CARLA simulator tests fix: add blueprint for test_brake steps for CARLA simulator tests Jul 16, 2024
@abanuelo abanuelo changed the title fix: add blueprint for test_brake steps for CARLA simulator tests fix: add blueprint for test_brake for CARLA simulator tests Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (f2c61b1) to head (211a9df).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   91.34%   91.36%   +0.02%     
==========================================
  Files          54       54              
  Lines       13535    13535              
==========================================
+ Hits        12363    12366       +3     
+ Misses       1172     1169       -3     

see 4 files with indirect coverage changes

@dfremont dfremont merged commit df5595c into main Jul 26, 2024
26 checks passed
@dfremont dfremont deleted the abanuelo/fix-carla-action-tests branch July 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants