Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Tweaks to PolygonalRegion #290

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Minor Tweaks to PolygonalRegion #290

merged 6 commits into from
Jul 29, 2024

Conversation

Eric-Vin
Copy link
Collaborator

Description

Minor tweaks to PolygonalRegion's __eq__ and hash functions.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin requested a review from dfremont July 11, 2024 10:48
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (a34460a) to head (cd2e219).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   91.33%   91.34%           
=======================================
  Files          54       54           
  Lines       13524    13537   +13     
=======================================
+ Hits        12352    12365   +13     
  Misses       1172     1172           
Files Coverage Δ
src/scenic/core/regions.py 87.28% <100.00%> (-0.13%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment above.

@Eric-Vin Eric-Vin requested a review from dfremont July 12, 2024 17:38
@Eric-Vin Eric-Vin marked this pull request as draft July 12, 2024 20:10
@Eric-Vin Eric-Vin marked this pull request as ready for review July 18, 2024 00:20
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dfremont dfremont merged commit 5f134ad into main Jul 29, 2024
8 of 24 checks passed
@dfremont dfremont deleted the RegionEqualsAndHash branch July 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants