Fix Verifai Sampler with more than 10 objects #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes problem with
VerifaiSampler
where there may be strange behavior when there are more than 10 samples in the scene. The problem is similar to the problem that was fixed recently in the VerifAI repo. The enumeration of objects goes as follows if there are more than 10 objects: 0, 1, 10, 2, 3, …, 9 when it expects 0, 1, 2, 3, …, 10 which causes a mismatch. This PR should fix this issue by checking that the parameter names match.This issue might pop up for other external samplers as well, but
VerifaiSampler
is fixed at least.Issue Link
#276
Checklist
pytest
and/or other meansAdditional Notes
N/A