Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Verifai Sampler with more than 10 objects #280

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

tcdanielh
Copy link
Contributor

@tcdanielh tcdanielh commented Jun 11, 2024

Description

Fixes problem with VerifaiSampler where there may be strange behavior when there are more than 10 samples in the scene. The problem is similar to the problem that was fixed recently in the VerifAI repo. The enumeration of objects goes as follows if there are more than 10 objects: 0, 1, 10, 2, 3, …, 9 when it expects 0, 1, 2, 3, …, 10 which causes a mismatch. This PR should fix this issue by checking that the parameter names match.

This issue might pop up for other external samplers as well, but VerifaiSampler is fixed at least.

Issue Link

#276

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Daniel! I'll add a test for this in a new PR (I can't easily add it to this one).

@dfremont dfremont merged commit 7cde613 into BerkeleyLearnVerify:main Jul 9, 2024
8 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifaiRange sampling values far beyond range (Fixed with solution mentioned on Slack, posting for the record)
2 participants