Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeCov .yml enhancements #264

Merged
merged 6 commits into from
May 16, 2024
Merged

fix: CodeCov .yml enhancements #264

merged 6 commits into from
May 16, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented May 9, 2024

Description

Adding the following changes to codecov.yml:

  • yml was incorrectly formatted (ie ran curl -X POST --data-binary @codecov.yml https://codecov.io/validate to verify that)
  • Readjusting patch thresholds to reduce noisy failures
  • regexes being applied to ignore certain simulator paths were incorrect. I decided to just list all those src/simulators folders to ignore
  • ignoring coverage on the test directory.
  • Increasing the difference threshold for project status to 5% given that we report "green" on anything that ranges between 70...100
  • Ignore coverage on any non-Python file

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin May 9, 2024 22:09
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (308c351) to head (0f2dbfe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   86.19%   91.12%   +4.93%     
==========================================
  Files         144       54      -90     
  Lines       25041    13478   -11563     
==========================================
- Hits        21583    12282    -9301     
+ Misses       3458     1196    -2262     

see 94 files with indirect coverage changes

@dfremont dfremont merged commit 6f37d6c into main May 16, 2024
4 of 24 checks passed
@dfremont dfremont deleted the abanuelo/code-cov-updates branch May 16, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants