Fix cross-entropy tests and leakage issue #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests for the interface with VerifAI's cross-entropy sampler keep failing occasionally since I chose the parameters poorly. This PR improves the tests in various ways and should ensure the false positive rate is extremely low. In the process I noticed an issue whereby the distribution of one sampling run would leak into the next (even after calling
resetExternalSampler
), so I've fixed that and added an assertion catching it.Issue Link
n/a
Checklist
pytest
and/or other meansAdditional Notes