Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driving Domain 3D Compatibility #254

Merged
merged 14 commits into from
May 15, 2024
Merged

Driving Domain 3D Compatibility #254

merged 14 commits into from
May 15, 2024

Conversation

Eric-Vin
Copy link
Collaborator

@Eric-Vin Eric-Vin commented May 2, 2024

Description

Allows for limited 3D mode functionality in the driving domain and associated simulators.

Issue Link

#229

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin requested a review from dfremont May 2, 2024 02:26
@Eric-Vin Eric-Vin changed the title Driving domain3 d mode Driving Domain 3D Compatibility May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.17%. Comparing base (9da70c3) to head (b00e8e7).
Report is 7 commits behind head on main.

Files Patch % Lines
src/scenic/simulators/carla/utils/utils.py 40.00% 3 Missing ⚠️
src/scenic/core/serialization.py 84.61% 2 Missing ⚠️
src/scenic/core/object_types.py 50.00% 1 Missing ⚠️
src/scenic/core/scenarios.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   86.14%   86.17%   +0.02%     
==========================================
  Files         144      144              
  Lines       24991    25080      +89     
==========================================
+ Hits        21529    21613      +84     
- Misses       3462     3467       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eric-Vin Eric-Vin marked this pull request as draft May 2, 2024 20:33
@Eric-Vin Eric-Vin marked this pull request as ready for review May 5, 2024 03:47
try:
import dill
except Exception:
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abanuelo Any way we can set up the coverage run to test both with and without the optional dependencies and take the union of the lines covered? (Maybe using --cov-append?) It looks like the coverage run uses test-full, but we should do test too to cover lines like this one.

tests/syntax/test_basic.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- just a few minor comments.

Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
@Eric-Vin Eric-Vin requested a review from dfremont May 9, 2024 01:09
@dfremont dfremont added this to the release 3.0.0rc1 milestone May 9, 2024
@dfremont dfremont merged commit 6e3ebc2 into main May 15, 2024
6 of 26 checks passed
@dfremont dfremont deleted the DrivingDomain3DMode branch May 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants