-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driving Domain 3D Compatibility #254
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 86.14% 86.17% +0.02%
==========================================
Files 144 144
Lines 24991 25080 +89
==========================================
+ Hits 21529 21613 +84
- Misses 3462 3467 +5 ☔ View full report in Codecov by Sentry. |
try: | ||
import dill | ||
except Exception: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abanuelo Any way we can set up the coverage run to test both with and without the optional dependencies and take the union of the lines covered? (Maybe using --cov-append
?) It looks like the coverage run uses test-full
, but we should do test
too to cover lines like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- just a few minor comments.
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
Description
Allows for limited 3D mode functionality in the driving domain and associated simulators.
Issue Link
#229
Checklist
pytest
and/or other meansAdditional Notes
N/A