Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carla Interface Convert record to Absolute Path #223

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Carla Interface Convert record to Absolute Path #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32db092
Minor tweak to Carla interface to resolve issue.
Eric-Vin Mar 25, 2024
05f2c5d
fix: ignoring src/scenic/simulators in codecov report
Mar 25, 2024
54c9d42
Merge branch 'abanuelo/update-code-cov-settings' into CarlaRecordDocu…
Eric-Vin Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ codecov:
layout: "reach, diff, flags, files"
behavior: default
require_ci_to_pass: true
ignore:
- "src/scenic/simulators/**"
cli:
plugins:
pycoverage:
Expand Down
2 changes: 2 additions & 0 deletions src/scenic/simulators/carla/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@
if not os.path.exists(self.record):
os.mkdir(self.record)
name = "{}/scenario{}.log".format(self.record, self.scenario_number)
# Carla is looking for an absolute path, so convert it if necessary.
name = os.path.abspath(name)

Check warning on line 143 in src/scenic/simulators/carla/simulator.py

View check run for this annotation

Codecov / codecov/patch

src/scenic/simulators/carla/simulator.py#L143 

Added line #L143 was not covered by tests
self.client.start_recorder(name)

# Create objects.
Expand Down
Loading