Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carla Interface Convert record to Absolute Path #223

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

Eric-Vin
Copy link
Collaborator

Description

Code to ensure Carla interface record parameter is an absolute path.

Issue Link

#21

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@dfremont @abanuelo Unable to test these changes with Carla at the moment due to server issues, but perhaps we could do so with the new simulator CI?

@Eric-Vin Eric-Vin requested a review from dfremont March 25, 2024 18:15
@Eric-Vin Eric-Vin linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.86%. Comparing base (d5a21fc) to head (54c9d42).

Files Patch % Lines
src/scenic/simulators/carla/simulator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   85.89%   85.86%   -0.03%     
==========================================
  Files         144      144              
  Lines       24767    24768       +1     
==========================================
- Hits        21274    21268       -6     
- Misses       3493     3500       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eric-Vin Eric-Vin requested a review from abanuelo April 3, 2024 23:20
@abanuelo
Copy link
Contributor

abanuelo commented Apr 3, 2024

Tested with @Eric-Vin and reported that files getting created with relative path of .

@Eric-Vin Eric-Vin merged commit e936093 into main Apr 3, 2024
24 of 26 checks passed
@Eric-Vin Eric-Vin deleted the CarlaRecordDocumentation branch April 3, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record parameter does not work with relative path
2 participants