Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable borrow when nft price is stale #130

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

thorseldon
Copy link
Contributor

  • Oracle Keeper set the price stale flag to true when NFT price changing sharply, e.g. up or down exceed 20%;
  • Borrowing logic add checks for the NFT price flag is valid or not;

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (b7b36e1) to head (992989f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
contracts/protocol/NFTOracle.sol 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   90.82%   90.91%   +0.08%     
==========================================
  Files          37       37              
  Lines        2868     2895      +27     
  Branches      450      455       +5     
==========================================
+ Hits         2605     2632      +27     
  Misses        263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorseldon thorseldon merged commit a76bb9e into main Feb 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant