Add extended pg_database columns for compatibility

BemiHQ · Dec 16, 2024 · 64fc085 · 64fc085
1 parent 3c44161
commit 64fc085
Show file tree

Hide file tree

Showing 3 changed files with 113 additions and 0 deletions.
diff --git a/src/query_handler_test.go b/src/query_handler_test.go
@@ -60,6 +60,10 @@ func TestHandleQuery(t *testing.T) {
 			"description": {"slot_name"},
 			"values":      {},
 		},
+		"SELECT oid, datname, datdba FROM pg_catalog.pg_database where oid = 1146": {
+			"description": {"oid", "datname", "datdba"},
+			"values":      {"1146", "memory", ""},
+		},
 		// pg_namespace
 		"SELECT DISTINCT(nspname) FROM pg_catalog.pg_namespace WHERE nspname != 'information_schema' AND nspname != 'pg_catalog'": {
 			"description": {"nspname"},

diff --git a/src/query_parser_table.go b/src/query_parser_table.go
@@ -90,6 +90,110 @@ func (parser *QueryParserTable) MakePgExtensionNode(alias string) *pgQuery.Node
     return parser.utils.MakeSubselectWithRowsNode(columns, rowsValues, alias)
 }
 
+// pg_catalog.pg_database -> VALUES(values...) t(columns...)
+func (parser *QueryParserTable) MakePgDatabaseNode(alias string) *pgQuery.Node {
+    targetList := []*pgQuery.Node{
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "oid",
+            pgQuery.MakeColumnRefNode([]*pgQuery.Node{pgQuery.MakeStrNode("oid")}, 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datname",
+            pgQuery.MakeColumnRefNode([]*pgQuery.Node{pgQuery.MakeStrNode("datname")}, 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datdba",
+            pgQuery.MakeAConstStrNode("", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "encoding",
+            pgQuery.MakeAConstStrNode("6", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datlocprovider",
+            pgQuery.MakeAConstStrNode("c", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datistemplate",
+            pgQuery.MakeAConstStrNode("f", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datallowconn",
+            pgQuery.MakeAConstStrNode("t", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datconnlimit",
+            pgQuery.MakeAConstStrNode("-1", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datfrozenxid",
+            pgQuery.MakeAConstStrNode("722", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datminmxid",
+            pgQuery.MakeAConstStrNode("1", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "dattablespace",
+            pgQuery.MakeAConstStrNode("1663", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datcollate",
+            pgQuery.MakeAConstStrNode("en_US.UTF-8", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datctype",
+            pgQuery.MakeAConstStrNode("en_US.UTF-8", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "daticulocale",
+            pgQuery.MakeAConstStrNode("", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "daticurules",
+            pgQuery.MakeAConstStrNode("", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datcollversion",
+            pgQuery.MakeAConstStrNode("", 0),
+            0,
+        ),
+        pgQuery.MakeResTargetNodeWithNameAndVal(
+            "datacl",
+            pgQuery.MakeAConstStrNode("", 0),
+            0,
+        ),
+    }
+
+    fromClause := &pgQuery.Node{
+        Node: &pgQuery.Node_RangeVar{
+            RangeVar: &pgQuery.RangeVar{
+                Schemaname:     "pg_catalog",
+                Relname:        "pg_database",
+                Inh:           true,
+                Relpersistence: "p",
+            },
+        },
+    }
+
+    return parser.utils.MakeSubselectFromNode(targetList, fromClause, alias)
+}
+
 // System pg_* tables
 func (parser *QueryParserTable) IsTableFromPgCatalog(qSchemaTable QuerySchemaTable) bool {
 	return parser.isPgCatalogSchema(qSchemaTable) &&

diff --git a/src/select_remapper_table.go b/src/select_remapper_table.go
@@ -18,6 +18,7 @@ const (
 	PG_TABLE_PG_CLASS              = "pg_class"
 	PG_TABLE_PG_EXTENSION          = "pg_extension"
 	PG_TABLE_PG_REPLICATION_SLOTS  = "pg_replication_slots"
+	PG_TABLE_PG_DATABASE           = "pg_database"
 
 	PG_TABLE_TABLES = "tables"
 )
@@ -81,6 +82,10 @@ func (remapper *SelectRemapperTable) RemapTable(node *pgQuery.Node) *pgQuery.Nod
 			// pg_replication_slots -> return nothing
 			tableNode := parser.MakeEmptyTableNode(PG_REPLICATION_SLOTS_COLUMNS, qSchemaTable.Alias)
 			return remapper.overrideTable(node, tableNode)
+		case PG_TABLE_PG_DATABASE:
+			// pg_catalog.pg_database -> extend with additional Postgres columns
+			tableNode := parser.MakePgDatabaseNode(qSchemaTable.Alias)
+			return remapper.overrideTable(node, tableNode)
 		default:
 			// pg_catalog.pg_* other system tables -> return as is
 			return node