Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in PyroShim #223

Merged
merged 24 commits into from
Jan 31, 2025
Merged

Fix bugs in PyroShim #223

merged 24 commits into from
Jan 31, 2025

Conversation

jfeser
Copy link
Contributor

@jfeser jfeser commented Jan 31, 2025 •
edited
Loading

  • Fix misuse of CondIndepStackFrame dim and missing size.
  • Enforce invariant that only one PyroShim on the stack takes effect.
  • Move msg attributes to avoid resetting of the infer dict related to use of auto guides.

Blocked by #214

@jfeser jfeser added the blocked label Jan 31, 2025
@jfeser jfeser removed the blocked label Jan 31, 2025
@jfeser jfeser requested a review from eb8680 January 31, 2025 19:29
@jfeser jfeser merged commit ffc8142 into master Jan 31, 2025
3 checks passed
@jfeser jfeser deleted the jf-pyro-shim-fixes branch January 31, 2025 20:20
@eb8680 eb8680 added this to the Post-release cleanup milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
status:awaiting review
Projects
None yet
Milestone
Post-release cleanup
Development

Successfully merging this pull request may close these issues.
2 participants
@jfeser @eb8680