Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable CI builds for Python 3.8 and 3.9 #13

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

eb8680
Copy link
Contributor

@eb8680 eb8680 commented Jul 2, 2024

Backwards compatibility issues with typing are causing unit tests to fail for Python 3.8 and 3.9, blocking unrelated PRs like #8. This PR disables CI builds for Python 3.8 and 3.9 temporarily to unblock #8 while we think about how to handle Python <3.10.

@eb8680 eb8680 added bug Something isn't working testing labels Jul 2, 2024
@eb8680 eb8680 requested a review from rvs314 July 2, 2024 14:11
Copy link
Contributor

@rvs314 rvs314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should we assume the lack of support for 3.8/3.9 to be temporary?

@eb8680
Copy link
Contributor Author

eb8680 commented Jul 2, 2024

Should we assume the lack of support for 3.8/3.9 to be temporary?

Yes, I opened a separate issue to track this - #14

@eb8680 eb8680 merged commit 8ef3cb9 into master Jul 2, 2024
2 of 3 checks passed
@eb8680 eb8680 deleted the eb-disable-ci-py38-39 branch July 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants