Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support param calls with event_dim in minipyro example #9

Closed
eb8680 opened this issue Jul 2, 2024 · 4 comments
Closed

Support param calls with event_dim in minipyro example #9

eb8680 opened this issue Jul 2, 2024 · 4 comments
Assignees
Labels

Comments

@eb8680
Copy link
Contributor

eb8680 commented Jul 2, 2024

There is at least one test in pyroapi that uses nested plates with manual dim arguments.

This exercises some nontrivial effect handler behavior, so after #8 lands, we should update our minipyro implementation to make those tests pass.

@eb8680 eb8680 added documentation Improvements or additions to documentation enhancement New feature or request example and removed documentation Improvements or additions to documentation enhancement New feature or request labels Jul 2, 2024
@rvs314 rvs314 self-assigned this Jul 2, 2024
@rvs314
Copy link
Contributor

rvs314 commented Jul 2, 2024

I think we already implement nested plates - the test you linked works. Do you mean the event_dim argument?

@eb8680
Copy link
Contributor Author

eb8680 commented Jul 2, 2024

plate doesn't take an event_dim argument, so I thought your comment was referring to the dim argument of plate. Did you mean the event_dim argument of param, or something else?

@rvs314
Copy link
Contributor

rvs314 commented Jul 2, 2024

Yes - that's what I meant. I can start looking at implementing the event_dim parameter of param if you think that'd be useful

@rvs314 rvs314 changed the title Support nested plates with manual dim in minipyro example Support param arguments with event_dim in minipyro example Jul 2, 2024
@rvs314 rvs314 changed the title Support param arguments with event_dim in minipyro example Support param calls with event_dim in minipyro example Jul 2, 2024
@eb8680
Copy link
Contributor Author

eb8680 commented Jul 2, 2024

Ah, OK. I don't think that's as interesting in terms of exercising effectful functionality, so let's not bother for now. I'll go ahead and close this issue.

@eb8680 eb8680 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants