Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional confirmation_height_frontier to get_nft_owner_assets #17

Open
ghost opened this issue Jul 30, 2021 · 0 comments
Open

add optional confirmation_height_frontier to get_nft_owner_assets #17

ghost opened this issue Jul 30, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Jul 30, 2021

https://docs.nano.org/commands/rpc-protocol/#account_info

the call to get_nft_owner_assets can be sped up if we can pass in a confirmation_height_frontier rather than calling account_info every time get_nft_owner_assets is called.

we have to get confirmation_height_frontier to make sure that the owner didn't change but if the client already knows the owner didn't change, and knows the previous confirmation_height_frontier, they can get the data faster by providing this value as input.

This would speed up the api calls on NFTS that we know didn't change ownership because we own the nfts and didn't send them anywhere.

unfortunately, banano isn't up to v22 yet so include_confirmed does nothing

@ghost ghost self-assigned this Jul 30, 2021
@ghost ghost added the enhancement New feature or request label Jul 30, 2021
@ghost ghost modified the milestones: 1.0.0, 0.0.2, 1.0.1 Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants