Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple performance hints #282

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

thatguy11325
Copy link
Contributor

Cython reports the following performance hints:

  performance hint: pyboy/core/ram.py:29:35: Index should be typed for more efficient access
  performance hint: pyboy/core/ram.py:39:39: Index should be typed for more efficient access
  performance hint: pyboy/core/ram.py:52:31: Index should be typed for more efficient access
  performance hint: pyboy/plugins/debug.py:560:67: Index should be typed for more efficient access
  performance hint: pyboy/plugins/debug.py:575:45: Index should be typed for more efficient access
  performance hint: pyboy/plugins/debug.py:815:27: Index should be typed for more efficient access

Not sure why the ones in debug.py are happening and the first ram hint is in __init__. But I took care of the other two at least.

Copy link
Owner

@Baekalfen Baekalfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@Baekalfen Baekalfen enabled auto-merge (rebase) November 10, 2023 16:10
@Baekalfen Baekalfen merged commit 7e17cd1 into Baekalfen:master Nov 10, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants