Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/34 #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix/34 #48

wants to merge 2 commits into from

Conversation

MiguelCano-ia
Copy link
Contributor

Queda revisar como quedo en mas pantallas (solo revise en iphone SE, XR y 4), y si agrada el diseño en estas mismas.

@Djkde01 Djkde01 linked an issue Sep 25, 2024 that may be closed by this pull request
iconName="backbone-logo"
[properties]="{
id: 'footer-logo',
class: 'size-20 text-primary-500 dark:text-primary-400 transition-all duration-300 ease-in-out'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducir espacio entre el texto y el logo cuando está en mobile.
Esto se pude hacer usando w-20 en lugar de size-20 (Size determina altura y ancho por igual, mientras w solo define el ancho y la altura es automáticamente calculada)

Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2024

Deploying main-page with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ea6c6f
Status: ✅  Deploy successful!
Preview URL: https://5b1eeb4e.main-page-3fk.pages.dev
Branch Preview URL: https://fix-34.main-page-3fk.pages.dev

View logs

JGaviria0
JGaviria0 previously approved these changes Oct 2, 2024
Copy link
Member

@JGaviria0 JGaviria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JGaviria0 JGaviria0 changed the base branch from main to development October 4, 2024 20:44
@JGaviria0 JGaviria0 dismissed their stale review October 4, 2024 20:44

The base branch was changed.

@JGaviria0 JGaviria0 changed the base branch from development to main October 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Cambiar Footer
3 participants