-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine #799
Conversation
Also adding in a couple of WFC3 narrow band filters to support other work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The make_vega_libfile function looks good! Thank you.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 42.44% 42.04% -0.41%
==========================================
Files 108 108
Lines 10132 10267 +135
==========================================
+ Hits 4301 4317 +16
- Misses 5831 5950 +119 ☔ View full report in Codecov by Sentry. |
Visually confirmed that the new and old filters are very similar. The differences seen in the tests must be due to very small changes in the filter band profiles. This was check for HST_ACS_WFC_F475W that is the first failure in the regression tests. The regression tests files need to be updated to account for these very small changes. |
Adding HST HRC FUV filters.
Adding in HST WFC3 narrow band filters.
Adding JWST NIRCam, NIRISS, and MIRI filters.
Added in code to make the vega.hd5 file after making the filters.hd5 file. (thanks @galaxyumi for the code to start from for this).
Added test to ensure the filters.hd5 and vega.hd5 are consistent (e.g. have the same filters).
Added new doc file with plots of all the filters. This replaces the text list of filter names.
Filters and vega library files updated in both locations for download (i.e., get_libfiles.py and box location).
Closes #757
Closes #796
Closes #786
Closes #809