Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine #799

Merged
merged 24 commits into from
May 23, 2024

Conversation

karllark
Copy link
Member

@karllark karllark commented Feb 14, 2024

Adding HST HRC FUV filters.
Adding in HST WFC3 narrow band filters.
Adding JWST NIRCam, NIRISS, and MIRI filters.
Added in code to make the vega.hd5 file after making the filters.hd5 file. (thanks @galaxyumi for the code to start from for this).
Added test to ensure the filters.hd5 and vega.hd5 are consistent (e.g. have the same filters).

Added new doc file with plots of all the filters. This replaces the text list of filter names.

Filters and vega library files updated in both locations for download (i.e., get_libfiles.py and box location).

Closes #757
Closes #796
Closes #786
Closes #809

@karllark
Copy link
Member Author

Also adding in a couple of WFC3 narrow band filters to support other work.

@karllark karllark changed the title adding in ACS HRC filters and enhancing the filter plotting routine adding in ACS HRC and JWST filters and enhancing the filter plotting routine Feb 15, 2024
@karllark karllark changed the title adding in ACS HRC and JWST filters and enhancing the filter plotting routine adding in ACS HRC, WFC3 narrow, and JWST filters and enhancing the filter plotting routine Feb 15, 2024
Copy link
Contributor

@galaxyumi galaxyumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make_vega_libfile function looks good! Thank you.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 16.89189% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 42.04%. Comparing base (08a232b) to head (b683663).
Report is 8 commits behind head on master.

Current head b683663 differs from pull request most recent head c9590a5

Please upload reports for the commit c9590a5 to get more accurate results.

Files Patch % Lines
beast/tools/make_libfile.py 4.68% 122 Missing ⚠️
beast/plotting/plot_filters.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   42.44%   42.04%   -0.41%     
==========================================
  Files         108      108              
  Lines       10132    10267     +135     
==========================================
+ Hits         4301     4317      +16     
- Misses       5831     5950     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark
Copy link
Member Author

Visually confirmed that the new and old filters are very similar. The differences seen in the tests must be due to very small changes in the filter band profiles. This was check for HST_ACS_WFC_F475W that is the first failure in the regression tests.

The regression tests files need to be updated to account for these very small changes.

This was referenced May 23, 2024
@karllark karllark changed the title adding in ACS HRC, WFC3 narrow, and JWST filters and enhancing the filter plotting routine adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine May 23, 2024
@karllark karllark merged commit bcc8cb5 into BEAST-Fitting:master May 23, 2024
8 of 9 checks passed
@karllark karllark deleted the add_acs_uv branch July 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants