Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters missing from newest vega.hd5 and filters.hd5 library files #786

Closed
petiay opened this issue May 3, 2023 · 1 comment · Fixed by #799
Closed

Filters missing from newest vega.hd5 and filters.hd5 library files #786

petiay opened this issue May 3, 2023 · 1 comment · Fixed by #799

Comments

@petiay
Copy link
Member

petiay commented May 3, 2023

This issue is related to the discussion in #755, PR#757, #759, and #778.

The newest version of the BEAST library files available either via manual download (Oct 2022) or via beast get_libfiles does not seem to contain all the filters in the version of the library files from March 2022.
For example, HST_ACS_WFC_F658N is missing. Generally there are 61 vs 189 filters available in the Oct vs the Mar 2022 files. I can not find a particular discussion to trim the list, so perhaps we just need to update the new list to make sure it includes all filters we need. @cmurray-astro , @galaxyumi , @karllark , comments are welcome.

I see some discussion in PR#757, but since a version of the library files from just after the discussion (Mar'22) includes the larger filter list, but the new version from Oct'22 is trimmed, then I am a bit confused.

@karllark
Copy link
Member

Narrow band filters adding in PR #799. This PR will close this issue. A new issues should be opened requested specific filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants