Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov GitHub action #26

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

jawsvk
Copy link

@jawsvk jawsvk commented Oct 1, 2020

Description of the change

Related Issues & Documents (if needed)

Issue #13

What type of PR is this? (check all applicable)

  • Refactoring existing code
  • Adding tests to existing code
  • New Feature
  • Bug Fix
  • Optimization
  • Documentation Update

QA Instructions(if necessary), Screenshots of Output or Recordings

Should see GitHub Actions running against Pull Requests

Added tests?

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation / readme or updated requirements.txt(if needed)?

  • Changed documentation in readme
  • No documentation needed
  • Updated requirements.txt

@jawsvk jawsvk force-pushed the add-codecov-github-action branch 3 times, most recently from 2118319 to e727641 Compare October 1, 2020 14:13
@jawsvk
Copy link
Author

jawsvk commented Oct 1, 2020

Finally it runs properly :)

@jawsvk jawsvk force-pushed the add-codecov-github-action branch from 0d91ba0 to b877151 Compare October 1, 2020 15:12
@BALaka-18
Copy link
Owner

BALaka-18 commented Oct 1, 2020

@jawsvk Great work ! I think there was some error with the corpus download part and the dependencies, right ? I couldn't figure out the solution for the nltk.download() part myself.
One last thing, just squash all commits to one single commit. I'll merge it then.

@jawsvk jawsvk force-pushed the add-codecov-github-action branch from b877151 to 2ceebe7 Compare October 1, 2020 15:35
@jawsvk
Copy link
Author

jawsvk commented Oct 1, 2020

@jawsvk Great work ! I think there was some error with the corpus download part and the dependencies, right ? I couldn't figure that out the solution for the nltk.download() part myself.
One last thing, just squash all commits to one single commit. I'll merge it then.

Done!

Copy link
Owner

@BALaka-18 BALaka-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging.

@BALaka-18 BALaka-18 merged commit b695dae into BALaka-18:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants