Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for .twig files #4

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

clemlatz
Copy link
Contributor

@clemlatz clemlatz commented Oct 24, 2024

What type of PR is this?

optimize: A new optimization

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

More detail description for this PR.

Twig is a template engine & language used in the Symfony framework, among others. It uses {# and #} as delimiting characters for multiline comments.

Note : currently, when trying to add a header to a non supported format, nwa will do nothing but still displays a success message eg

2024/10/24 10:06:32 INFO file has been modified path=src/AppBundle/Resources/views/Article/show.html.twig

I think it would be better to display an error message stating that the format is unsupported, but that goes far beyond my very weak knowledge of Go.

@justlorain
Copy link
Member

There is indeed a bug in handling unsupported file formats, and I will fix it later. Thank you for discovering it.

Please resolve the conflicts, and then we can merge this PR.

@clemlatz clemlatz force-pushed the add-twig-files-support branch from 954e0a4 to b897fa2 Compare October 24, 2024 16:04
@clemlatz clemlatz force-pushed the add-twig-files-support branch from b897fa2 to 486ad65 Compare October 24, 2024 16:07
@justlorain justlorain merged commit 4b98a3f into B1NARY-GR0UP:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants