[sairedis/syncd] Implement bulk get support (#1509) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Feb 28, 2025
dgsudharsan
suggested changes
Mar 1, 2025
|
I cherry picked Steven's commit. Maybe I can create a new pick from the source. |
|
@stepanblyschak We need this diff |
DEPENDS ON sonic-net/sonic-swss-common#966. Implement bulk get support for SAIRedis, Syncd, SaiPlayer and VSlib.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| for (uint32_t idx = 0; idx < object_count; idx++) | ||
| { | ||
| if (object_statuses[idx] == SAI_STATUS_SUCCESS) |
Check notice
Code scanning / CodeQL
FIXME comment Note
Comment on lines
2266
to
2359
| switch (api) | ||
| { | ||
| case SAI_COMMON_API_BULK_CREATE: | ||
|
|
||
| { | ||
| sai_object_id_t switch_id = m_sai->switchIdQuery(local_ids[0]); | ||
| std::vector<sai_object_id_t> ids(object_count); | ||
|
|
||
| for (uint32_t it = 0; it < object_count; it++) | ||
| { | ||
| if (m_sai->switchIdQuery(local_ids[it]) != switch_id || | ||
| switch_id == SAI_NULL_OBJECT_ID) | ||
| { | ||
| SWSS_LOG_THROW("invalid switch_id translated from VID %s", | ||
| sai_serialize_object_id(local_ids[it]).c_str()); | ||
| } | ||
| } | ||
|
|
||
| std::vector<uint32_t> attr_counts(object_count); | ||
|
|
||
| std::vector<const sai_attribute_t*> attr_lists(object_count); | ||
|
|
||
| for (uint32_t idx = 0; idx < object_count; idx++) | ||
| { | ||
| attr_counts[idx] = attributes[idx]->get_attr_count(); | ||
| attr_lists[idx] = attributes[idx]->get_attr_list(); | ||
| } | ||
|
|
||
| switch_id = translate_local_to_redis(switch_id); | ||
|
|
||
| status = m_sai->bulkCreate(object_type, | ||
| switch_id, | ||
| object_count, | ||
| attr_counts.data(), | ||
| attr_lists.data(), | ||
| mode, | ||
| ids.data(), | ||
| statuses.data()); | ||
|
|
||
| if (status == SAI_STATUS_SUCCESS) | ||
| { | ||
| for (uint32_t it = 0; it < object_count; it++) | ||
| { | ||
| match_redis_with_rec(ids[it], local_ids[it]); | ||
|
|
||
| SWSS_LOG_INFO("saved VID %s to RID %s", | ||
| sai_serialize_object_id(local_ids[it]).c_str(), | ||
| sai_serialize_object_id(ids[it]).c_str()); | ||
| } | ||
| } | ||
|
|
||
| return status; | ||
| } | ||
| break; | ||
|
|
||
| case SAI_COMMON_API_BULK_REMOVE: | ||
|
|
||
| { | ||
| std::vector<sai_object_id_t> ids(object_count); | ||
|
|
||
| for (uint32_t it = 0; it < object_count; it++) | ||
| { | ||
| ids[it] = translate_local_to_redis(local_ids[it]); | ||
| } | ||
|
|
||
| status = m_sai->bulkRemove(object_type, object_count, ids.data(), mode, statuses.data()); | ||
| } | ||
| break; | ||
|
|
||
| case SAI_COMMON_API_BULK_SET: | ||
|
|
||
| { | ||
| std::vector<sai_object_id_t> ids(object_count); | ||
|
|
||
| for (uint32_t it = 0; it < object_count; it++) | ||
| { | ||
| ids[it] = translate_local_to_redis(local_ids[it]); | ||
| } | ||
|
|
||
| std::vector<sai_attribute_t> attr_list; | ||
|
|
||
| // route can have multiple attributes, so we need to handle them all | ||
| for (const auto &alist: attributes) | ||
| { | ||
| attr_list.push_back(alist->get_attr_list()[0]); | ||
| } | ||
|
|
||
| status = m_sai->bulkSet(object_type, object_count, ids.data(), attr_list.data(), mode, statuses.data()); | ||
| } | ||
| break; | ||
|
|
||
| case SAI_COMMON_API_BULK_GET: | ||
|
|
||
| { |
Check notice
Code scanning / CodeQL
Long switch case Note
Comment on lines
+671
to
+680
| switch (object_type) | ||
| { | ||
| case SAI_OBJECT_TYPE_PORT: | ||
| ptr = m_apis.port_api->get_ports_attribute; | ||
| break; | ||
|
|
||
| SWSS_LOG_ERROR("not implemented, FIXME"); | ||
| default: | ||
| SWSS_LOG_ERROR("not implemented %s, FIXME", sai_serialize_object_type(object_type).c_str()); | ||
| return SAI_STATUS_NOT_IMPLEMENTED; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON sonic-net/sonic-swss-common#966.
Implement bulk get support for SAIRedis, Syncd, SaiPlayer and VSlib.