Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code sync] Merge code from sonic-net/sonic-sairedis:202411 to 202412 #23

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

mssonicbld
Copy link
Collaborator

* d884ff9a - (origin/202411) [syncd] Move logSet logGet under mutex to prevent race condition (#1520) (#1538) (2025-02-20) [Kamil Cudnik]
* ec8b3c30 - Fix pipeline errors related to rsyslogd and libswsscommon installation (#1535) (2025-02-19) [mssonicbld]
* 6b263b8e - [FC] Support Policer Counter (#1533) (2025-02-19) [mssonicbld]
* e53489e5 - [syncd] Update log level for bulk api (#1532) (2025-02-18) [Jianyue Wu]
* 7ae00e53 - Define bulk chunk size and bulk chunk size per counter ID (#1528) (2025-02-11) [mssonicbld]
* f35e743a - [nvidia] Skip SAI discovery on ports (#1524) (2025-02-07) [mssonicbld]
* bf049ed2 - Use sonictest pool instead of sonic-common and fix arm64 issue. (#1516) (2025-02-05) [mssonicbld]
* ffe371d6 - [syncd] Support bulk set in INIT_VIEW mode (#1517) (2025-02-05) [mssonicbld]<br>```

mssonicbld and others added 9 commits February 5, 2025 13:27
Support bulk set in INIT_VIEW mode.
1. Use sonictest pool instead of sonic-common
2. Fix arm64 build error.
Given that modern systems have lots of ports, performing SAI discovery takes very long time, e.g. (8 sec) for 256 port system. This has a big impact of fast-boot downtime and the discovery itself is not required for Nvidia platform fast-boot.

Same applies to Nvidia fastfast-boot (aka warm-boot), yet needs to be tested separately.
Define bulk chunk size and bulk chunk size per counter ID.
This is to resolve the VS test failure in #1457, which is caused by loop dependency.
In PR #1457, new fields `bulk_chunk_size` and `bulk_chunk_size_per_prefix` have been introduced to `sai_redis_flex_counter_group_parameter_t` whose instances are initialized by orchagent.
However, the orchagent is still compiled with the old sairedis header, which prevents both new fields from being uninitialized which in turn fails vs test.

We have to split this PR into two:
1. #1519 which updates the header sairedis.h only. the motivation is to compile swss(orchagent) with both new fields initiated.
2. #1457 contains all the rest of code

The order to merge:
1. #1519
2. sonic-net/sonic-swss#3391
3. #1457
[syncd] Update log level for bulk api
Added the implantation for policer counter -
Support in POLICER group and sai_serialize functions
Unit Tests: Included unit tests to add and remove policer counter.
…n (#1535)

On arm64 (and maybe sometimes amd64), rsyslogd appears to need a second or two to actually fully exit. The current code expects it to exit practically instantly. Add a sleep of 2 seconds to give it some time. Also enable some logging so that the commands being run can be seen.

Also, fix an error related to libswsscommon not getting installed due to new dependencies being added. Solve this by using apt install to install the package, which brings in any necessary dependencies.
…20) (#1538)

[syncd] Move logSet logGet under mutex to prevent race condition
@mssonicbld mssonicbld merged commit 9fbe10d into Azure:202412 Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants