Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM_SUBSCRIPTION_ID after LogonToAzure with MSI #703

Merged

Conversation

SteffenBoThomsen
Copy link
Contributor

@SteffenBoThomsen SteffenBoThomsen commented Jan 23, 2025

Problem

This PR ensures the right ARM_SUBSCRIPTION_ID is exported after authenticating with the LogonToAzure() function wth MSI.
When using MSI, the /etc/profile.d/deploy_server.sh is sourced, which contains the ARM_SUBSCRIPTION_ID set to the control plane subscription. This ensures, that if the expected ARM_SUBSCRIPTION_ID set before the call to this function is also set after the sourcing.

…s sourced.

This overwrites the ARM_SUBSCRIPTION_ID with the control plane subscription id.
This ensures that the right ARM_SUBSCRIPTION_ID is set after sourcing.
@SteffenBoThomsen SteffenBoThomsen requested a review from a team as a code owner January 23, 2025 16:06
@SteffenBoThomsen SteffenBoThomsen requested review from dhruvmicrosoft and removed request for a team January 23, 2025 16:06
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hdamecharla hdamecharla merged commit b0116d2 into Azure:development Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants