Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] Add warnings for usage of RSA-OAEP and RSA1_5 #32818

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

maorleger
Copy link
Member

Packages impacted by this PR

@azure/keyvault-keys

Issues associated with this PR

Resolves #32636
Resolves #32751

Describe the problem that is addressed by this PR

This PR accomplishes two goals:

  1. Use generated enum names instead of overwriting them with our hand-authored
    ones in keyvault-keys
  2. Adds a warning about using RSA1_5 and RSA-OAEP by proxy of (1) - exposing the
    generated enum names directly

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

https://github.com/Azure/azure-rest-api-specs/pull/32422/files should be
//approved and merged before this can be merged.

Command used to generate this PR: (Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/keyvault-keys

@maorleger maorleger marked this pull request as ready for review January 31, 2025 22:42
@maorleger maorleger requested a review from timovv as a code owner January 31, 2025 22:42
@maorleger maorleger merged commit 8377f7b into Azure:main Feb 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update RSA algorithm documentation Use client customization for keyvault-keys cryptography models
3 participants