Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-tool] Update migrate-package for ARM packages and update snippets #32550

Merged
merged 56 commits into from
Jan 14, 2025

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/dev-tool
  • @azure/arm-voiceservices
  • @azure/arm-webpubsub
  • @azure/arm-workloads
  • @azure/arm-workloadssapvirtualinstance

Issues associated with this PR

Describe the problem that is addressed by this PR

Updates the migration tool for ARM packages and updates snippets for the above packages.

This adds the following for the migration tool.

  • Fixes for samples-dev to add Promise<void> to all non-marked methods
  • Change beforeEach and afterEach to use arrow functions instead of function
  • Fix the timeout issue on it and it.skip to move it to an options parameter.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added dev-tool Issues related to the Azure SDK for JS dev-tool Mgmt This issue is related to a management-plane library. labels Jan 14, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mpodwysocki mpodwysocki merged commit 706086f into main Jan 14, 2025
30 checks passed
@mpodwysocki mpodwysocki deleted the feat/webpubsub-arm-esm branch January 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants