Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document Intelligence] Live tests - Update to tme resource #32464

Merged

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Jan 8, 2025

Packages impacted by this PR

@azure-rest/ai-document-intelligence

Issues associated with this PR

Live test deployment failing

Updates to the resource fixes the pipeline

Updates to the bicep file

  1. Changed blobStorageAccount parameter from 'azuresdktrainingdata' to 'azuresdktrainingdatatme'.

  2. batchTrainingDataResultContainer parameter for batch training data result container, batchTrainingResultSasProperties parameter with associated properties. New var DOCUMENT_INTELLIGENCE_BATCH_TRAINING_DATA_RESULT_CONTAINER_SAS_URL

  3. API Version Updates:

    • Updated apiVersion from '2024-04-01-preview' to '2024-10-01'.
    • Updated the resource definition for cognitiveServicesAccount to use the new API version.

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru HarshaNalluru marked this pull request as ready for review January 8, 2025 14:27
@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change auth to use managed identity?

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence-rest - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru
Copy link
Member Author

Is it possible to change auth to use managed identity?

AAD was not fully supported before and we had to rely on API key instead.
Will need more testing before more updates, will cover as a future PR.

@HarshaNalluru HarshaNalluru merged commit ced505e into Azure:main Jan 9, 2025
25 checks passed
@HarshaNalluru HarshaNalluru deleted the harshan/doc-intel/fix-live-tests branch January 9, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants