Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor OpenTelemetry Exporter] Add Long-Interval Statsbeat Warmup Time #32421

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

JacksonWeber
Copy link
Member

Packages impacted by this PR

@azure/monitor-opentelemetry-exporter

Describe the problem that is addressed by this PR

Add 15 second warmup timer to the long-interval statsbeat in accordance with the spec. Will reduce long interval statsbeat noise.

Are there test cases added in this PR? (If not, why?)

Yes

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@JacksonWeber JacksonWeber changed the title [Monitor OpenTelemetry Exporter] Add Lon-Interval Statsbeat Warmup Time [Monitor OpenTelemetry Exporter] Add Long-Interval Statsbeat Warmup Time Jan 7, 2025
Copy link
Member

@harsimar harsimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks ok, just a question about why the statsCollectionLongInterval was changed to a minute

@JacksonWeber JacksonWeber requested a review from harsimar January 10, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants