-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitor OpenTelemetry Exporter] Add Long-Interval Statsbeat Warmup Time #32421
Open
JacksonWeber
wants to merge
17
commits into
Azure:main
Choose a base branch
from
JacksonWeber:jacksonweber/add-statsbeat-warmup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Monitor OpenTelemetry Exporter] Add Long-Interval Statsbeat Warmup Time #32421
JacksonWeber
wants to merge
17
commits into
Azure:main
from
JacksonWeber:jacksonweber/add-statsbeat-warmup
+25
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
JacksonWeber
changed the title
[Monitor OpenTelemetry Exporter] Add Lon-Interval Statsbeat Warmup Time
[Monitor OpenTelemetry Exporter] Add Long-Interval Statsbeat Warmup Time
Jan 7, 2025
harsimar
reviewed
Jan 9, 2025
sdk/monitor/monitor-opentelemetry-exporter/src/export/statsbeat/longIntervalStatsbeatMetrics.ts
Outdated
Show resolved
Hide resolved
harsimar
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok, just a question about why the statsCollectionLongInterval was changed to a minute
harsimar
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
Describe the problem that is addressed by this PR
Add 15 second warmup timer to the long-interval statsbeat in accordance with the spec. Will reduce long interval statsbeat noise.
Are there test cases added in this PR? (If not, why?)
Yes
Checklists