[mgmt] migrate mgmt package to esm 10 #32370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
qiaozha,
MaryGao,
a team,
ckairen and
jeremymeng
as code owners
github-actions
bot
added
the
Mgmt
|
API change check API changes are not detected in this pull request. |
mpodwysocki
approved these changes
Dec 30, 2024
mpodwysocki
reviewed
Dec 30, 2024
| "esm", | ||
| "commonjs" | ||
| ], | ||
| "esmDialects": [ |
There was a problem hiding this comment.
Are we shipping for React-Native and Browser support? If not, please remove the esmDialects.
qiaozha
reviewed
Jan 6, 2025
| @@ -87,8 +77,8 @@ | |||
| "test:browser": "echo skipped", | |||
| "test:node": "echo skipped", | |||
| "unit-test": "npm run unit-test:node && npm run unit-test:browser", | |||
| "unit-test:browser": "echo skipped", | |||
| "unit-test:node": "dev-tool run vendored cross-env TEST_MODE=playback npm run integration-test:node", | |||
| "unit-test:browser": "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32184
@azure/arm-datadog
@azure/arm-datafactory
@azure/arm-datalake-analytics
@azure/arm-datamigration